[cleanup] Clean up underscores in some test names
Tests written with the GoogleTest framework should
not use underscores in test names.
Cleaning up some stragglers.
```
CFX_FolderFontInfoTest
CFX_WindowsRenderDeviceTest
FPDFRenderPatternEmbedderTest.LoadError_547706
FXCRYPT.CRYPT_ArcFour*
```
etc
Bug: 42270790
Change-Id: I763b592d7714a39de5f660a7ac7ed5e1dc9cdd52
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/125410
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Ho Cheung <hocheung@chromium.org>
diff --git a/core/fdrm/fx_crypt_unittest.cpp b/core/fdrm/fx_crypt_unittest.cpp
index f4ae16b..64f3efa 100644
--- a/core/fdrm/fx_crypt_unittest.cpp
+++ b/core/fdrm/fx_crypt_unittest.cpp
@@ -245,7 +245,7 @@
0xd4, 0x19, 0xdb, 0x06, 0xc1));
}
-TEST(FXCRYPT, CRYPT_ArcFourSetup) {
+TEST(FXCRYPT, CRYPTArcFourSetup) {
{
static const uint8_t
kNullPermutation[CRYPT_rc4_context::kPermutationLength] = {
@@ -303,7 +303,7 @@
}
}
-TEST(FXCRYPT, CRYPT_ArcFourCrypt) {
+TEST(FXCRYPT, CRYPTArcFourCrypt) {
static const uint8_t kDataShort[] =
"The Quick Fox Jumped Over The Lazy Brown Dog.";
static const uint8_t kDataLong[] =
diff --git a/core/fpdfapi/render/fpdf_render_pattern_embeddertest.cpp b/core/fpdfapi/render/fpdf_render_pattern_embeddertest.cpp
index 68505e5..4cb6e15 100644
--- a/core/fpdfapi/render/fpdf_render_pattern_embeddertest.cpp
+++ b/core/fpdfapi/render/fpdf_render_pattern_embeddertest.cpp
@@ -9,7 +9,7 @@
class FPDFRenderPatternEmbedderTest : public EmbedderTest {};
-TEST_F(FPDFRenderPatternEmbedderTest, LoadError_547706) {
+TEST_F(FPDFRenderPatternEmbedderTest, LoadError547706) {
// Test shading where object is a dictionary instead of a stream.
ASSERT_TRUE(OpenDocument("bug_547706.pdf"));
ScopedEmbedderTestPage page = LoadScopedPage(0);
diff --git a/core/fxge/cfx_folderfontinfo.h b/core/fxge/cfx_folderfontinfo.h
index ec53226..e97bc4c 100644
--- a/core/fxge/cfx_folderfontinfo.h
+++ b/core/fxge/cfx_folderfontinfo.h
@@ -46,7 +46,7 @@
bool GetFontCharset(void* hFont, FX_Charset* charset) override;
protected:
- friend class CFX_FolderFontInfoTest;
+ friend class CFXFolderFontInfoTest;
class FontFaceInfo {
public:
diff --git a/core/fxge/cfx_folderfontinfo_unittest.cpp b/core/fxge/cfx_folderfontinfo_unittest.cpp
index 8cdb8b9..9b67f57 100644
--- a/core/fxge/cfx_folderfontinfo_unittest.cpp
+++ b/core/fxge/cfx_folderfontinfo_unittest.cpp
@@ -31,9 +31,9 @@
} // namespace
-class CFX_FolderFontInfoTest : public ::testing::Test {
+class CFXFolderFontInfoTest : public ::testing::Test {
public:
- CFX_FolderFontInfoTest() {
+ CFXFolderFontInfoTest() {
AddDummyFont(kArial, CHARSET_FLAG_ANSI);
AddDummyFont(kCourierNew, CHARSET_FLAG_ANSI);
AddDummyFont(kTimesNewRoman, 0);
@@ -71,7 +71,7 @@
CFX_FolderFontInfo font_info_;
};
-TEST_F(CFX_FolderFontInfoTest, TestFindFont) {
+TEST_F(CFXFolderFontInfoTest, TestFindFont) {
// Find "Symbol" font
void* font = FindFont(/*weight=*/0, /*bItalic=*/false, FX_Charset::kSymbol,
FXFONT_FF_ROMAN, kSymbol, /*bMatchName=*/true);
diff --git a/core/fxge/cfx_windowsrenderdevice_embeddertest.cpp b/core/fxge/cfx_windowsrenderdevice_embeddertest.cpp
index b637b46..2dc4025 100644
--- a/core/fxge/cfx_windowsrenderdevice_embeddertest.cpp
+++ b/core/fxge/cfx_windowsrenderdevice_embeddertest.cpp
@@ -20,7 +20,7 @@
} // namespace
-class CFX_WindowsRenderDeviceTest : public EmbedderTest {
+class CFXWindowsRenderDeviceTest : public EmbedderTest {
public:
void SetUp() override {
EmbedderTest::SetUp();
@@ -46,7 +46,7 @@
std::unique_ptr<CFX_WindowsRenderDevice> m_driver;
};
-TEST_F(CFX_WindowsRenderDeviceTest, SimpleClipTriangle) {
+TEST_F(CFXWindowsRenderDeviceTest, SimpleClipTriangle) {
CFX_Path path_data;
CFX_PointF p1(0.0f, 0.0f);
CFX_PointF p2(0.0f, 100.0f);
@@ -60,7 +60,7 @@
path_data, &kIdentityMatrix, CFX_FillRenderOptions::WindingOptions()));
}
-TEST_F(CFX_WindowsRenderDeviceTest, SimpleClipRect) {
+TEST_F(CFXWindowsRenderDeviceTest, SimpleClipRect) {
CFX_Path path_data;
path_data.AppendRect(0.0f, 100.0f, 200.0f, 0.0f);
@@ -69,7 +69,7 @@
path_data, &kIdentityMatrix, CFX_FillRenderOptions::WindingOptions()));
}
-TEST_F(CFX_WindowsRenderDeviceTest, GargantuanClipRect) {
+TEST_F(CFXWindowsRenderDeviceTest, GargantuanClipRect) {
CFX_Path path_data;
path_data.AppendRect(-257698020.0f, -257697252.0f, 257698044.0f,
@@ -83,7 +83,7 @@
path_data, &kIdentityMatrix, CFX_FillRenderOptions::WindingOptions()));
}
-TEST_F(CFX_WindowsRenderDeviceTest, GargantuanClipRectWithBaseClip) {
+TEST_F(CFXWindowsRenderDeviceTest, GargantuanClipRectWithBaseClip) {
CFX_Path path_data;
const FX_RECT kBaseClip(0, 0, 5100, 6600);
