commit 3e144b8c23d7c52ed36329e87f0cb01f38ec1ed7
author Raymes Khoury <raymes@chromium.org> Wed Sep 30 11:46:41 2015 +0200
committer Jochen Eisinger <jochen@chromium.org> Wed Sep 30 11:46:41 2015 +0200
tree 4ed8ecb304a11f865d4067c792644736d1ab5ccf
parent 0fef7dd405ac85660dbeddd2e47620daffa70cb5

Leak per-isolate data in pdfium

Right now we're freeing per-isolate data everytime a document is destroyed even
though it may be in use by other documents. For now we leak the per-isolate
data until crbug.com/531339 is fixed.

BUG=531339
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1372353002 .

Patch from Raymes Khoury <raymes@chromium.org>.

fpdfsdk/src/javascript/JS_Runtime.cpp

diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp
index 1e1486d..7ce8a53 100644
--- a/fpdfsdk/src/javascript/JS_Runtime.cpp
+++ b/fpdfsdk/src/javascript/JS_Runtime.cpp
@@ -63,7 +63,13 @@
     delete m_ContextArray.GetAt(i);
 
   m_ContextArray.RemoveAll();
-  FXJS_ReleaseRuntime(GetIsolate(), m_context);
+
+  // TODO(raymes): Currently we're freeing per-isolate data everytime a
+  // document is destroyed even though it may be in use by other documents. For
+  // now we leak the per-isolate data (when m_isolateManaged is false) until
+  // crbug.com/531339 is fixed.
+  if (m_isolateManaged)
+    FXJS_ReleaseRuntime(GetIsolate(), m_context);
 
   m_pApp = NULL;
   m_pDocument = NULL;