commit 4e7a55ebf491df0999b9fb21aeee259495b943eb
author Dan Sinclair <dsinclair@chromium.org> Sat Nov 04 03:32:58 2017 +0000
committer Chromium commit bot <commit-bot@chromium.org> Sat Nov 04 03:32:58 2017 +0000
tree ad47bc85a2f8c315de0716250fe130ebc697f5cb
parent 5e35931f90d83e471e4d215034abb4dcb92fac3a

Remove flag parameter from CXFA_Node::CreateSamePacketNode

The parameter is never changed from the default so, removed and moved
the default value into the method as needed.

Change-Id: Ifab40ac511b9a0ab879e5c696c6e0b6c84e14541
Reviewed-on: https://pdfium-review.googlesource.com/17616
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

xfa/fxfa/parser/cxfa_node.cpp

diff --git a/xfa/fxfa/parser/cxfa_node.cpp b/xfa/fxfa/parser/cxfa_node.cpp
index b46a0bd..5962e76 100644
--- a/xfa/fxfa/parser/cxfa_node.cpp
+++ b/xfa/fxfa/parser/cxfa_node.cpp
@@ -337,10 +337,9 @@
   return nodes;
 }
 
-CXFA_Node* CXFA_Node::CreateSamePacketNode(XFA_Element eType,
-                                           uint32_t dwFlags) {
+CXFA_Node* CXFA_Node::CreateSamePacketNode(XFA_Element eType) {
   CXFA_Node* pNode = m_pDocument->CreateNode(m_ePacket, eType);
-  pNode->SetFlag(dwFlags, true);
+  pNode->SetFlag(XFA_NodeFlag_Initialized, true);
   return pNode;
 }
 

xfa/fxfa/parser/cxfa_node.h

diff --git a/xfa/fxfa/parser/cxfa_node.h b/xfa/fxfa/parser/cxfa_node.h
index 50fec5b..f3273d6 100644
--- a/xfa/fxfa/parser/cxfa_node.h
+++ b/xfa/fxfa/parser/cxfa_node.h
@@ -108,8 +108,7 @@
   CXFA_Node* GetNodeItem(XFA_NODEITEM eItem, XFA_ObjectType eType) const;
   std::vector<CXFA_Node*> GetNodeList(uint32_t dwTypeFilter,
                                       XFA_Element eTypeFilter);
-  CXFA_Node* CreateSamePacketNode(XFA_Element eType,
-                                  uint32_t dwFlags = XFA_NodeFlag_Initialized);
+  CXFA_Node* CreateSamePacketNode(XFA_Element eType);
   CXFA_Node* CloneTemplateToForm(bool bRecursive);
   CXFA_Node* GetTemplateNode() const;
   void SetTemplateNode(CXFA_Node* pTemplateNode);