Remove font cache from CFGAS_DefaultFontManager.
The cache is never accessed and retains fonts in memory that will
not be used anymore.
Change-Id: Ia763499dc88a99741a85afc4ddd09257e8e1119c
Reviewed-on: https://pdfium-review.googlesource.com/38898
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
diff --git a/xfa/fgas/font/cfgas_defaultfontmanager.cpp b/xfa/fgas/font/cfgas_defaultfontmanager.cpp
index 4d0ff20..d8ffd54 100644
--- a/xfa/fgas/font/cfgas_defaultfontmanager.cpp
+++ b/xfa/fgas/font/cfgas_defaultfontmanager.cpp
@@ -49,8 +49,6 @@
}
}
}
- if (pFont)
- m_CacheFonts.push_back(pFont);
return pFont;
}
@@ -64,7 +62,5 @@
pFont = pFontMgr->LoadFont(static_cast<const wchar_t*>(nullptr),
dwFontStyles, 0xFFFF);
}
- if (pFont)
- m_CacheFonts.push_back(pFont);
return pFont;
}
diff --git a/xfa/fgas/font/cfgas_defaultfontmanager.h b/xfa/fgas/font/cfgas_defaultfontmanager.h
index 2afe9eb..5a2bc12 100644
--- a/xfa/fgas/font/cfgas_defaultfontmanager.h
+++ b/xfa/fgas/font/cfgas_defaultfontmanager.h
@@ -24,9 +24,6 @@
RetainPtr<CFGAS_GEFont> GetDefaultFont(CFGAS_FontMgr* pFontMgr,
const WideStringView& wsFontFamily,
uint32_t dwFontStyles);
-
- private:
- std::vector<RetainPtr<CFGAS_GEFont>> m_CacheFonts;
};
#endif // XFA_FGAS_FONT_CFGAS_DEFAULTFONTMANAGER_H_
