commit 627c1580a7ea0d59a63a0adc87f49d4ffe4d546c
author Hui Yingst <nigi@chromium.org> Mon Dec 14 20:18:47 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Dec 14 20:18:47 2020 +0000
tree 0857dc30ec91562d78d1df0e4c35a12da7b3c495
parent 0c2e668748fb26a2c9dd0368d9474914a3599f9b

Declare the checksums static in fpdf_flatten_embeddertest.cpp.

The checksums in fpdf_flatten_embeddertest.cpp are an aggregate
constexpr type. Declare the checksums static to comply with the style
guide.

Change-Id: I078b6b19c5b4331bbb6af9a80ac30de44923747e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/76972
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>

fpdfsdk/fpdf_flatten_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_flatten_embeddertest.cpp b/fpdfsdk/fpdf_flatten_embeddertest.cpp
index cb8d310..1a81d4b 100644
--- a/fpdfsdk/fpdf_flatten_embeddertest.cpp
+++ b/fpdfsdk/fpdf_flatten_embeddertest.cpp
@@ -40,14 +40,18 @@
 
 TEST_F(FPDFFlattenEmbedderTest, BUG_861842) {
 #if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-  constexpr char kCheckboxChecksum[] = "95fdaa000e81c80892b8d370f77be970";
+  static constexpr char kCheckboxChecksum[] =
+      "95fdaa000e81c80892b8d370f77be970";
 #else
 #if defined(OS_WIN)
-  constexpr char kCheckboxChecksum[] = "95fba3cb7bce7e0d3c94279f60984e17";
+  static constexpr char kCheckboxChecksum[] =
+      "95fba3cb7bce7e0d3c94279f60984e17";
 #elif defined(OS_APPLE)
-  constexpr char kCheckboxChecksum[] = "6aafcb2d98da222964bcdbf5aa1f4f1f";
+  static constexpr char kCheckboxChecksum[] =
+      "6aafcb2d98da222964bcdbf5aa1f4f1f";
 #else
-  constexpr char kCheckboxChecksum[] = "594265790b81df2d93120d33b72a6ada";
+  static constexpr char kCheckboxChecksum[] =
+      "594265790b81df2d93120d33b72a6ada";
 #endif
 #endif  // defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
 
@@ -64,7 +68,7 @@
   UnloadPage(page);
 
   // TODO(crbug.com/861842): This should not render blank.
-  constexpr char kBlankPageHash[] = "48400809c3862dae64b0cd00d51057a4";
+  static constexpr char kBlankPageHash[] = "48400809c3862dae64b0cd00d51057a4";
   VerifySavedDocument(100, 120, kBlankPageHash);
 }
 
@@ -107,9 +111,9 @@
 
 TEST_F(FPDFFlattenEmbedderTest, BUG_890322) {
 #if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-  constexpr char kChecksum[] = "793689536cf64fe792c2f241888c0cf3";
+  static constexpr char kChecksum[] = "793689536cf64fe792c2f241888c0cf3";
 #else
-  constexpr char kChecksum[] = "6c674642154408e877d88c6c082d67e9";
+  static constexpr char kChecksum[] = "6c674642154408e877d88c6c082d67e9";
 #endif
   ASSERT_TRUE(OpenDocument("bug_890322.pdf"));
   FPDF_PAGE page = LoadPage(0);
@@ -128,9 +132,9 @@
 
 TEST_F(FPDFFlattenEmbedderTest, BUG_896366) {
 #if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-  constexpr char kChecksum[] = "c3cccfadc4c5249e6aa0675e511fa4c3";
+  static constexpr char kChecksum[] = "c3cccfadc4c5249e6aa0675e511fa4c3";
 #else
-  constexpr char kChecksum[] = "f71ab085c52c8445ae785eca3ec858b1";
+  static constexpr char kChecksum[] = "f71ab085c52c8445ae785eca3ec858b1";
 #endif
   ASSERT_TRUE(OpenDocument("bug_896366.pdf"));
   FPDF_PAGE page = LoadPage(0);