commit a98c08922d62e1d68d8dada74f2c695dd8d83e19
author K. Moon <kmoon@chromium.org> Sat Nov 12 00:44:23 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Nov 12 00:44:23 2022 +0000
tree 7f2d3d4b7457a5a3af83456856a7575da4c60df5
parent 4948d0e50b5c9427ed1902d97bf9f3b3bd658dbb

Ensure checkout_skia is defined before use

Checks that checkout_skia is defined before dereferencing in PDFium's
top-level BUILD.gn. When used in non-PDFium projects (like Chromium),
build/config/gclient_args.gni likely doesn't define checkout_skia.

Bug: pdfium:1938
Change-Id: I2d8fb5affe79c1a13075463e908900031a3a9960
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/101210
Auto-Submit: K. Moon <kmoon@chromium.org>
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 070df30..7339b2a 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -582,7 +582,7 @@
 
   # TODO(crbug.com/pdfium/1832): Remove !is_android when //third_party/expat is
   # available.
-  if (checkout_skia && !is_android) {
+  if (defined(checkout_skia) && checkout_skia && !is_android) {
     deps += [ "//skia" ]
   }
 }