commit c363b521bcef5b96fc0397c0631b6dd18887b70c
author Lei Zhang <thestig@chromium.org> Sat Jan 14 02:48:42 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Jan 14 02:48:42 2023 +0000
tree ad2ddad5b4dcfeec37ae1a0eacd41037e3d740de
parent 7fd93825f401d6fe08bced3b882f9c71d03b26c2

Remove an obsolete TODO in fx_skia_device.cpp.

In Upsample(), all the possible bpp values have been handled. Thus the
default case in the switch statement does not need the TODO and does not
need to set anything since it is not reachable.

Change-Id: Ib43b88b9e31715b5fd8463aeb3348086f3aaccf1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/103234
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>

core/fxge/skia/fx_skia_device.cpp

diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp
index 69082ea..b287d7a 100644
--- a/core/fxge/skia/fx_skia_device.cpp
+++ b/core/fxge/skia/fx_skia_device.cpp
@@ -687,8 +687,7 @@
       pSource->DebugVerifyBitmapIsPreMultiplied();
       break;
     default:
-      NOTREACHED();  // TODO(bug_11) ensure that all cases are covered
-      colorType = SkColorType::kUnknown_SkColorType;
+      NOTREACHED();
   }
   SkImageInfo imageInfo =
       SkImageInfo::Make(width, height, colorType, alphaType);